The art of the PR: Part 1

Go Time: Golang, Software Engineering

In this episode, we will be exploring PRs. What makes a good PR? How do you give the best PR review? Is there such thing as too small, or big of a PR? We’ll be debating the details, and trying to help our fellow gophers perfect the art of the PR. We are joined by three wonderful guests Jeff Hernandez, Sarah Duncan, and Natasha Dykes. Hosted by Angelica Hill & Natalie Pistunovich.

Join the discussion

Changelog++ members save 9 minutes on this episode because they made the ads disappear. Join today!

Sponsors:

• Sourcegraph – Transform your code into a queryable database to create customizable visual dashboards in seconds. Sourcegraph recently launched Code Insights — now you can track what really matters to you and your team in your codebase. See how other teams are using this awesome feature at about.sourcegraph.com/code-insights
• FireHydrant – The reliability platform for every developer. Incidents impact everyone, not just SREs. FireHydrant gives teams the tools to maintain service catalogs, respond to incidents, communicate through status pages, and learn with retrospectives. Small teams up to 10 people can get started for free with all FireHydrant features included. No credit card required to sign up. Learn more at firehydrant.io
• Honeycomb – Guess less, know more. When production is running slow, it’s hard to know where problems originate: is it your application code, users, or the underlying systems? With Honeycomb you get a fast, unified, and clear understanding of the one thing driving your business: production. Join the swarm and try Honeycomb free today at honeycomb.io/changelog
• Chronosphere – Chronosphere is the observability platform for cloud-native teams operating at scale. When it comes to observability, teams need a reliable, scalable, and efficient solution so they can know about issues well before their customers do. Teams choose Chronosphere to help them move faster than the competition. Learn more and get a demo at chronosphere.io.

Featuring:

• Jeff Hernandez – GitHub
• Sarah Duncan – X
• Natasha Dykes – GitHub
• Angelica Hill – GitHub, LinkedIn, X
• Natalie Pistunovich – GitHub, X

Show Notes:

• The Art of Giving and Receiving Code Reviews (Gracefully)

Something missing or broken? PRs welcome!

Chương

1. Opener (00:00:00)

2. Sponsor: Sourcegraph (00:00:54)

https://info.sourcegraph.com/changelog

3. Intro (00:03:59)

4. Introducing the panel (00:04:42)

5. What exactly is a PR? (00:06:24)

6. PR size matters (00:13:14)

7. Like baking a cake (00:19:58)

8. Sponsor: FireHydrant (00:24:13)

https://firehydrant.io/

9. Tips for reviewing PRs (00:25:46)

10. Which parts of the code to review (00:29:41)

11. Code reviewer locality concerns (00:38:26)

12. Code review norms (00:44:22)

13. Sponsor: Honeycomb (00:49:13)

https://honeycomb.io/changelog

14. Sponsor: Chronosphere (00:50:33)

https://chronosphere.io

15. Teaching code review (00:52:44)

16. Unpopular Opinions! (00:55:47)

17. Jeff's unpop (00:56:09)

18. Sarah's unpop (00:56:52)

19. Natasha's unpop (00:59:21)

20. Natalie's new project (01:00:08)

21. Goodbye! (01:00:42)

22. Outro (01:01:02)